Skip to content

Fix mypy strict equality #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mypy strict equality #1404

wants to merge 1 commit into from

Conversation

kbaikov
Copy link
Contributor

@kbaikov kbaikov commented Aug 8, 2025

No description provided.

@kbaikov kbaikov force-pushed the mypy-fixes6 branch 4 times, most recently from de6092a to c79395d Compare August 14, 2025 12:13
@kbaikov
Copy link
Contributor Author

kbaikov commented Aug 24, 2025

Ping @jdavid any comments/review to this PR?

@jdavid
Copy link
Member

jdavid commented Sep 2, 2025

Hi @kbaikov , sorry for the delay, have been busy.

-    assert ObjectType.BLOB == blob.type
+    assert int(ObjectType.BLOB) == blob.type

The thing is ObjectType.BLOB == blob.type should work and this should be tested in the unit tests.

If we are to make strict_equality = True then blob.type should return ObjectType.BLOB instead of 3.
But this is likely difficult to do because blob.type is defined in C while ObjectType is defined in Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbaikov @jdavid